exo/game-engine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(demo): remove unnecessary clearRenderingBos() calls in window setup methods

Browse Source
This commit is contained in:
extio-de
2025-12-29 21:39:37 +01:00
parent d96ff09ab4
commit eb0b2d853c
2 changed files with 1 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
README.md
View File

@@ -664,7 +664,6 @@ public class MyModule extends AbstractClientModule {
private void showChildWindow() { private void showChildWindow() {
// Setup child window content // Setup child window content
this.childWindow.clearRenderingBos();
var button = renderingBoPool.acquire("okButton", ControlRenderingBo.class) var button = renderingBoPool.acquire("okButton", ControlRenderingBo.class)
.setType(ButtonControl.class) .setType(ButtonControl.class)
.setCaption("OK") .setCaption("OK")
@@ -691,13 +690,10 @@ public class MyModule extends AbstractClientModule {
**Direct Rendering Objects** **Direct Rendering Objects**
Windows maintain their own renderer working set. Add rendering objects directly using `putRenderingBo()`. Use `clearRenderingBos()` to reset window content before rebuilding: Windows maintain their own renderer working set. Add rendering objects directly using `putRenderingBo()`:
```java ```java
private void setupWindow(Window window) { private void setupWindow(Window window) {
// Clear previous content
window.clearRenderingBos();
// Add new rendering objects // Add new rendering objects
var label = renderingBoPool.acquire("myLabel", ControlRenderingBo.class) var label = renderingBoPool.acquire("myLabel", ControlRenderingBo.class)
.setType(LabelControl.class) .setType(LabelControl.class)
@@ -745,9 +741,6 @@ public class MyModule extends AbstractClientModule {
} }
private void setupScrollableWindow() { private void setupScrollableWindow() {
// Clear and setup window title
this.scrollableWindow.clearRenderingBos();
var title = renderingBoPool.acquire("title", DrawFontRenderingBo.class) var title = renderingBoPool.acquire("title", DrawFontRenderingBo.class)
.setText("Scrollable Content") .setText("Scrollable Content")
.setSize(28) .setSize(28)
@@ -965,7 +958,6 @@ public class MyWindow extends Window {
``` ```
**Content Management:** **Content Management:**
- Use `clearRenderingBos()` before rebuilding window content to avoid stale objects
- Call `putRenderingBo()` to add or update individual rendering objects - Call `putRenderingBo()` to add or update individual rendering objects
- Call `removeRenderingBo()` to remove specific objects by ID - Call `removeRenderingBo()` to remove specific objects by ID
- Create reusable `WindowComponent` implementations for complex, self-contained UI elements - Create reusable `WindowComponent` implementations for complex, self-contained UI elements

6
src/test/java/de/extio/game_engine/demo/DemoModule.java
View File

@@ -324,8 +324,6 @@ public class DemoModule extends AbstractClientModule {
} }
private void setupSecondaryWindow() { private void setupSecondaryWindow() {
this.secondaryWindow.clearRenderingBos();
var bo = this.renderingBoPool.acquire("DemoModule_SecondaryWindow_Text", DrawFontRenderingBo.class) var bo = this.renderingBoPool.acquire("DemoModule_SecondaryWindow_Text", DrawFontRenderingBo.class)
.setText(this.localizationService.translate("test-5").replace("\\n", "\n")) .setText(this.localizationService.translate("test-5").replace("\\n", "\n"))
.setSize(32) .setSize(32)
@@ -345,7 +343,6 @@ public class DemoModule extends AbstractClientModule {
} }
private void setupThemeSelectionWindow() { private void setupThemeSelectionWindow() {
this.themeSelectionWindow.clearRenderingBos();
this.themeSelectionByControlId.clear(); this.themeSelectionByControlId.clear();
final var themes = this.themeManager.getAvailableThemeNames(); final var themes = this.themeManager.getAvailableThemeNames();
@@ -407,7 +404,6 @@ public class DemoModule extends AbstractClientModule {
} }
private void setupLanguageSelectionWindow() { private void setupLanguageSelectionWindow() {
this.languageSelectionWindow.clearRenderingBos();
this.languageSelectionByControlId.clear(); this.languageSelectionByControlId.clear();
final var languages = this.localizationService.getLanguages(); final var languages = this.localizationService.getLanguages();
@@ -471,8 +467,6 @@ public class DemoModule extends AbstractClientModule {
} }
private void setupScrollAreaWindow() { private void setupScrollAreaWindow() {
this.scrollAreaWindow.clearRenderingBos();
var bo = this.renderingBoPool.acquire("DemoModule_ScrollAreaWindow_Title", DrawFontRenderingBo.class) var bo = this.renderingBoPool.acquire("DemoModule_ScrollAreaWindow_Title", DrawFontRenderingBo.class)
.setText(this.localizationService.translate("test-8")) .setText(this.localizationService.translate("test-8"))
.setSize(28) .setSize(28)